feat(flexible-outcalls): IC-1947 generate CanisterHttpRequestContext from flexible args#9019
Open
feat(flexible-outcalls): IC-1947 generate CanisterHttpRequestContext from flexible args#9019
Conversation
fspreiss
changed the title
Base automatically changed from
fspreiss/CON-1640-flex-outcalls-extend-context
to
master
February 24, 2026 07:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
generate_from_flexible_argsconstructor toCanisterHttpRequestContextthat builds a context from the newFlexibleCanisterHttpRequestArgswith a randomly-selected node committee and configurablemin_responses/max_responsescounts.Validates
ReplicationCountsinvariants (1 <= total_requests <= N,0 <= min_responses <= max_responses <= total_requests) and default tototal_requests = N, min_responses = floor(2N/3) + 1, max_responses = Nwhen no replication config is provided.Refactors shared validation logic (
validate_transform_principal,validate_url_length) out of the existing new constructor so bothgenerate_from_argsandgenerate_from_flexible_argsreuse the same checks, and simplifies the non-replicated node selection usingrand::seq::IteratorRandom::choose.