feat: use test safe transitions #6396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
dskloetd
approved these changes
Feb 11, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
# Motivation Revert #6396 because thanks to a different way of mocking the transitions for test purposes (without vite), those workaround are not needed anymore when migrating to Svelte v5. # Resources New solution to mock the animation for test purposes with Svelte v5 providing by Testing Library in testing-library/svelte-testing-library#284 (comment) # Changes Revert #6396 # Tests I tested the revert and new way of mocking with Svelte v5 in #6404. The tests did not throw the keyword `TypeError: Cannot set properties of undefined (setting 'onfinish')`. Signed-off-by: David Dal Busco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Svelte v5 requires the web animation API which is not supported in emulated testing environment. That is why we added some "test safe transition directive" to Gix components (see PR dfinity/gix-components#573) and why we are using those transitions in this PR.
Notes
Changes
testSafe...directives instead of directly using transition of Svelte