feat(disburse-maturity): Disburse maturity modal #6911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrasinskis
changed the title
1 task
yhabib
reviewed
Jun 2, 2025
frontend/src/lib/modals/neurons/NnsDisburseMaturityModal.svelte
Outdated
Show resolved
Hide resolved
frontend/src/lib/modals/neurons/NnsDisburseMaturityModal.svelte
Outdated
Show resolved
Hide resolved
commit 4efbb58 Author: Max Strasinsky <[email protected]> Date: Mon Jun 2 13:16:23 2025 +0200 Apply new consts commit 39e5e5e Author: Max Strasinsky <[email protected]> Date: Mon Jun 2 13:14:56 2025 +0200 New constants MIN_DISBURSEMENT_WITH_VARIANCE
commit eb43670 Author: Max Strasinsky <[email protected]> Date: Mon Jun 2 13:30:36 2025 +0200 Fix ICP constant commit 08815a5 Author: Max Strasinsky <[email protected]> Date: Mon Jun 2 13:25:18 2025 +0200 Revert "Cleanup" This reverts commit ea18ead. commit ea18ead Author: Max Strasinsky <[email protected]> Date: Mon Jun 2 13:22:43 2025 +0200 Cleanup commit 4efbb58 Author: Max Strasinsky <[email protected]> Date: Mon Jun 2 13:16:23 2025 +0200 Apply new consts commit 39e5e5e Author: Max Strasinsky <[email protected]> Date: Mon Jun 2 13:14:56 2025 +0200 New constants MIN_DISBURSEMENT_WITH_VARIANCE
yhabib
approved these changes
Jun 2, 2025
Base automatically changed from
disburse-maturity/display-disburse-button
to
main
June 2, 2025 16:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To simplify the process of claiming matured rewards and avoid the extra steps of creating and disbursing a new neuron, the disburse maturity feature is introduced for NNS neurons (this approach is already used for SNS neurons).
This PR adds the "Disburse" modal to the neuron page.
Out of scope
Jira
Changes
NnsDisburseMaturityModalcomponent that heavily reuses DisburseMaturityModal component.Tests
disburse-maturity.mp4
Todos
Not yet