Skip to content

docs(pr): update checklist in PR template #6914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

docs(pr): update checklist in PR template #6914

merged 2 commits into from
Jun 4, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Jun 2, 2025 •
edited
Loading

Motivation

Update the PR template to include a to-do for accessibility checks, ensuring they are always part of new pull requests and their reviews.

Changes

  • Update template with a new check for a11y.
  • Reword existing one to simplify flow.

Tests

Not necessary.

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@yhabib yhabib marked this pull request as ready for review June 2, 2025 15:00
@yhabib yhabib requested a review from a team as a code owner June 2, 2025 15:00
mstrasinskis
mstrasinskis reviewed Jun 4, 2025
View reviewed changes
mstrasinskis
mstrasinskis approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yhabib yhabib force-pushed the yhabib/chore/a11y branch from abbc273 to a63e95e Compare June 4, 2025 14:13
@yhabib yhabib changed the title docs(pr): add a11y check to PR template docs(pr): update checklist in PR template Jun 4, 2025
@yhabib yhabib enabled auto-merge June 4, 2025 14:16
@yhabib yhabib force-pushed the yhabib/chore/a11y branch from a3cb96c to 6194988 Compare June 4, 2025 17:30
@yhabib yhabib added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 9c74d2f Jun 4, 2025
36 checks passed
@yhabib yhabib deleted the yhabib/chore/a11y branch June 4, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis