Skip to content

perf: adjust eager load key size threshold #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

perf: adjust eager load key size threshold #338

wants to merge 3 commits into from

Conversation

maksymar
Copy link
Contributor

@maksymar maksymar commented Jun 6, 2025

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025 •
edited
Loading

canbench 🏋 (dir: ./benchmarks/memory_manager) d7c265c 2025-06-06 17:07:23 UTC

✅ ./benchmarks/memory_manager/canbench_results.yml is up to date
📦 canbench_results_memory-manager.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes detected 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes detected 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes detected 👍
    counts:   [total 3 | regressed 0 | improved 0 | new 0 | unchanged 3]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025 •
edited
Loading

canbench 🏋 (dir: ./benchmarks/compare) d7c265c 2025-06-06 17:08:29 UTC

✅ ./benchmarks/compare/canbench_results.yml is up to date
📦 canbench_results_compare.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes detected 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes detected 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes detected 👍
    counts:   [total 18 | regressed 0 | improved 0 | new 0 | unchanged 18]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025 •
edited
Loading

canbench 🏋 (dir: ./benchmarks/btreemap) d7c265c 2025-06-06 17:09:02 UTC

✅ ./benchmarks/btreemap/canbench_results.yml is up to date
📦 canbench_results_btreemap.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   Both regressions and improvements detected! 🔴🟢
    counts:   [total 285 | regressed 54 | improved 25 | new 0 | unchanged 206]
    change:   [max +136.93M | p75 +9.92M | median 0 | p25 0 | min -32.16M]
    change %: [max +18.47% | p75 +1.22% | median 0.00% | p25 0.00% | min -3.75%]

  heap_increase:
    status:   No significant changes detected 👍
    counts:   [total 285 | regressed 0 | improved 0 | new 0 | unchanged 285]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes detected 👍
    counts:   [total 285 | regressed 0 | improved 0 | new 0 | unchanged 285]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------

Only significant changes:
| status | name                             | calls |     ins |  ins Δ% | HI |  HI Δ% | SMI |  SMI Δ% |
|--------|----------------------------------|-------|---------|---------|----|--------|-----|---------|
|   +    | btreemap_v2_contains_vec_32_64   |       | 482.69M | +18.47% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_vec_32_64        |       | 489.84M | +18.21% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_contains_vec_32_256  |       | 521.33M | +18.02% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_contains_vec_32_512  |       | 541.82M | +17.63% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_contains_vec_32_128  |       | 501.66M | +17.02% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_vec_32_256       |       | 534.27M | +16.90% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_contains_vec_32_32   |       | 424.14M | +16.73% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_vec_32_128       |       | 509.99M | +16.61% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_contains_vec_32_8    |       | 420.33M | +16.56% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_vec_32_32        |       | 430.88M | +16.43% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_vec_32_512       |       | 558.80M | +16.41% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_contains_vec_32_4    |       | 428.42M | +16.28% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_vec_32_8         |       | 426.84M | +16.27% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_contains_vec_32_16   |       | 435.55M | +16.13% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_vec_32_4         |       | 434.89M | +16.00% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_vec_32_16        |       | 442.14M | +15.85% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_contains_vec_32_1024 |       | 591.43M | +15.02% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_pop_last_vec_32_32   |       |   1.06B | +14.24% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_pop_first_vec_32_32  |       |   1.08B | +13.75% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_pop_last_vec_32_64   |       |   1.10B | +13.65% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_pop_last_vec_32_4    |       |   1.05B | +13.60% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_get_vec_32_1024      |       | 627.73M | +13.55% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_pop_last_vec_32_8    |       |   1.05B | +13.34% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_pop_last_vec_32_16   |       |   1.05B | +13.30% |  0 |  0.00% |   0 |   0.00% |
|   +    | btreemap_v2_pop_last_vec_32_128  |       |   1.21B | +12.50% |  0 |  0.00% |   0 |   0.00% |
|  ...   | ... 29 rows omitted ...          |       |         |         |    |        |     |         |
|   -    | btreemap_v2_remove_vec_32_16     |       | 865.63M |  -2.27% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_remove_vec_32_64     |       | 959.28M |  -2.30% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_remove_vec_32_32     |       | 858.61M |  -2.32% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_remove_vec_32_4      |       | 855.10M |  -2.37% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_remove_vec_32_8      |       | 848.57M |  -2.43% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_insert_blob_32_16    |       | 513.81M |  -2.48% |  0 |  0.00% |  11 |   0.00% |
|   -    | btreemap_v2_insert_blob_32_512   |       | 603.10M |  -2.63% |  0 |  0.00% |  91 |   0.00% |
|   -    | btreemap_v2_insert_blob_32_256   |       | 565.27M |  -2.63% |  0 |  0.00% |  49 |   0.00% |
|   -    | btreemap_v2_remove_blob_32_1024  |       | 971.90M |  -2.67% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_insert_blob_32_4     |       | 503.01M |  -2.76% |  0 |  0.00% |   8 |   0.00% |
|   -    | btreemap_v2_insert_blob_32_1024  |       | 692.04M |  -2.78% |  0 |  0.00% | 173 |   0.00% |
|   -    | btreemap_v2_insert_blob_64_128   |       | 650.10M |  -3.00% |  0 |  0.00% |  34 |   0.00% |
|   -    | btreemap_v2_remove_blob_64_128   |       | 897.49M |  -3.06% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_insert_blob_32_8     |       | 509.44M |  -3.07% |  0 |  0.00% |   9 |   0.00% |
|   -    | btreemap_v2_insert_blob_32_128   |       | 534.44M |  -3.17% |  0 |  0.00% |  28 |   0.00% |
|   -    | btreemap_v2_remove_blob_32_512   |       | 843.99M |  -3.22% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_remove_blob_32_16    |       | 693.18M |  -3.29% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_insert_blob_32_32    |       | 518.95M |  -3.35% |  0 |  0.00% |  13 |   0.00% |
|   -    | btreemap_v2_remove_blob_32_256   |       | 771.96M |  -3.42% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_insert_blob_32_64    |       | 524.26M |  -3.47% |  0 |  0.00% |  18 |   0.00% |
|   -    | btreemap_v2_remove_blob_32_128   |       | 736.38M |  -3.48% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_remove_blob_32_4     |       | 686.79M |  -3.63% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_remove_blob_32_32    |       | 700.88M |  -3.66% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_remove_blob_32_64    |       | 726.37M |  -3.68% |  0 |  0.00% |   0 |   0.00% |
|   -    | btreemap_v2_remove_blob_32_8     |       | 685.56M |  -3.75% |  0 |  0.00% |   0 |   0.00% |

ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change

---------------------------------------------------
CSV results saved to canbench_results.csv

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025 •
edited
Loading

canbench 🏋 (dir: ./benchmarks/vec) 4780528 2025-06-07 08:49:50 UTC

❌ ./benchmarks/vec/canbench_results.yml is not up to date
If the performance change is expected, run canbench --persist [--csv] to update the benchmark results.
📦 canbench_results_vec.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes detected 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  heap_increase:
    status:   No significant changes detected 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes detected 👍
    counts:   [total 16 | regressed 0 | improved 0 | new 0 | unchanged 16]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maksymar