Add FromDhall/ToDhall for LocalTime/ZonedTime/UTCTime#2300
Merged
Gabriella439 merged 1 commit intodhall-lang:masterfrom Sep 11, 2021
Merged
Add FromDhall/ToDhall for LocalTime/ZonedTime/UTCTime#2300Gabriella439 merged 1 commit intodhall-lang:masterfrom
FromDhall/ToDhall for LocalTime/ZonedTime/UTCTime#2300Gabriella439 merged 1 commit intodhall-lang:masterfrom
Conversation
amesgen
force-pushed
the
datetime-instances
branch
from
b42f489 to
8fe0aa8
Compare
Collaborator
|
@amesgen: I think what you have now is fine, meaning that I think it's good for |
Collaborator
|
Thank you! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2286.
One thing to discuss is how to handle decoding
UTCTime. Right now, any input timezone is accepted, and then converted to UTC. One could also argue that only the00:00input timezone should be accepted, with an error thrown otherwise. I would be fine with both approaches.