Skip to content

<>| is accepted as empty union type #2338

Merged
Gabriella439 merged 1 commit intodhall-lang:masterfrom
hagl:extra_bar_after_empty_union
Nov 27, 2021
Merged

<>| is accepted as empty union type #2338
Gabriella439 merged 1 commit intodhall-lang:masterfrom
hagl:extra_bar_after_empty_union

Conversation

@hagl
Copy link

@hagl hagl commented Nov 27, 2021

When reading through the dhall-haskell sources I found that an optional bar | is accepted after an empty union type (probably some left-over code from a refactoring):

Welcome to the Dhall v1.40.1 REPL! Type :help for more information.
⊢ <>|

<>

This is is not accepted by the dhall grammar or the standard implementation:

<>|
dhall: user error ((input):1:3:
  |
1 | <>|
  |   ^
unexpected '|'
expecting "!=", "&&", "++", "--", "//", "//\\", "/\", "::", "==", "===", "{-", "||", '#', '*', '+', '.', ':', '?', '∧', '≡', '⩓', '⫽', crlf newline, end of input, newline, space, or tab
)

@Gabriella439 Gabriella439 merged commit 31350b7 into dhall-lang:master Nov 27, 2021
@Gabriella439
Copy link
Collaborator

Nice catch! Thank you for fixing that 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants