Fix dhall freeze --cache to support v21.0.0#2350
Merged
Gabriella439 merged 3 commits intomasterfrom Dec 15, 2021
Merged
Conversation
Fixes #2347 This now uses `missing sha256:…` for the frozen import so that the import still succeeds even if the hash doesn't match (which was the original intention of the `--cached` flag; otherwise it would be useless).
sjakobi
approved these changes
Dec 15, 2021
… as suggested by @sjakobi
Gabriella439
added a commit
to dhall-lang/dhall-lang
that referenced
this pull request
Apr 2, 2023
Note that the large number of changes to use `missing` is intentional (it's because of the `dhall` upgrade). See: dhall-lang/dhall-haskell#2350
Gabriella439
added a commit
that referenced
this pull request
Apr 2, 2023
The fix in #2350 introduced a new problem: now `dhall freeze --cache --all` is not idempotent and will fail if you run it a second time on the same due to trying to resolve the `missing` import. This change fixes that.
Gabriella439
added a commit
that referenced
this pull request
Apr 2, 2023
The fix in #2350 introduced a new problem: now `dhall freeze --cache --all` is not idempotent and will fail if you run it a second time on the same due to trying to resolve the `missing` import. This change fixes that.
locallycompact
pushed a commit
to locallycompact/dhall-haskell
that referenced
this pull request
Apr 26, 2023
The fix in dhall-lang#2350 introduced a new problem: now `dhall freeze --cache --all` is not idempotent and will fail if you run it a second time on the same due to trying to resolve the `missing` import. This change fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2347
This now uses
missing sha256:…for the frozen import so that theimport still succeeds even if the hash doesn't match (which was the
original intention of the
--cachedflag; otherwise it would beuseless).