Allow Some in with expression#2354
Merged
Gabriella439 merged 3 commits intodhall-lang:masterfrom Dec 31, 2021
Merged
Conversation
sjakobi
approved these changes
Dec 22, 2021
Collaborator
sjakobi
left a comment
There was a problem hiding this comment.
Thanks! Ideally we'd also have a test for this in tests/parser/success/unit. Would you like to give this a try?
To generate the corresponding .dhallb CBOR output, you can run the dhall:tasty tests in this repo with the --accept flag, e.g.
cabal test dhall:tasty --test-options=--accept
Also see https://github.com/dhall-lang/dhall-lang/tree/master/tests#running-parser-tests.
Contributor
Author
|
Gave it a try! |
Collaborator
|
Thank you for fixing that! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for small discrepancy between
dhall-haskelland the reference implementation/standard.Before:
After: