Merged
Conversation
The main change is to remove the stringly-typed example for substitutions, not only because I don't want to encourage that pattern, but also because it contains a confusing use of the `maximum` function where it's being used as a partial `fromSuccess :: Expector a -> a` function by abusing the `Foldable` instance for `Validation`
sjakobi
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change is to remove the stringly-typed example for
substitutions, not only because I don't want to encourage that
pattern, but also because it contains a confusing use of the
maximumfunction where it's being used as a partialfromSuccess :: Expector a -> afunction by abusing theFoldableinstance forValidation