Freeze expressions providing a custom context and normalizer#2478
Merged
Gabriella439 merged 2 commits intodhall-lang:masterfrom Jan 5, 2023
Merged
Freeze expressions providing a custom context and normalizer#2478Gabriella439 merged 2 commits intodhall-lang:masterfrom
Gabriella439 merged 2 commits intodhall-lang:masterfrom
Conversation
…a custom normalizer
Collaborator
|
Maybe these could take an |
Gabriella439
approved these changes
Jan 5, 2023
Collaborator
Gabriella439
left a comment
Gabriella439
left a comment
There was a problem hiding this comment.
Perfect! This looks amazing. Thank you for doing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds variants for the functions found in the
Dhall.Freezemodule that also take a context and a normalizer. Those functions are prefixed withcustomin order to maintain backwards compatibility. Code common to the existing functions and the new ones were moved to a bunch of helper functions such that there is no unnecessary code duplication.