Port to GHC-9.8.2 (missing: dhall-{lsp-server,nix,nixpkgs})#2584
Closed
lucasdicioccio wants to merge 4 commits intodhall-lang:mainfrom
Closed
Port to GHC-9.8.2 (missing: dhall-{lsp-server,nix,nixpkgs})#2584lucasdicioccio wants to merge 4 commits intodhall-lang:mainfrom
lucasdicioccio wants to merge 4 commits intodhall-lang:mainfrom
Conversation
Contributor
|
I think these look like sensible changes. Given that GHC 9.8.3 will be out in a few days, and the Stackage LTS after that, I think it would be good to merge and release this, so we can keep Dhall in Stackage LTS. Any reason this is still 'draft' @lucasdicioccio ? |
Contributor
|
I am not sure how much of the work here is still pending on the default branch, but basic GHC 9.8 usage should already work since |
Author
I think we can close this PR. Sorry the time I can allocate for open-source contribs is pretty narrow since a while ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting something to upgrade to 9.8.2, taking baby-steps absent #2583 .
My goal is to compile with
-Werrorwith 9.8.2 (I run cabal 3.10.3.0 but that shouldn't matter much) then pass tests (without -Werror then with).headcalls toNonEmpty.head . NonEmpty.fromListexcept indhall/src/Dhall/Tags.hs(a more human-friendly symbol is welcomed) anddhall-openapi/src/Dhall/Kubernetes/Types.hs(we may expect the parser to occur at a boundary where human-readable errors are paramount)liftA2importsdhall-{lspt-server,nix,nixpkgs})(tbc: blocked onhnix)I'm struggling to find cycles to feel free to take over the pull-request.