-
-
Notifications
You must be signed in to change notification settings - Fork 20
refactor: upgrade to Angular 19 #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
**Note:** This commit contains breaking changes, as we now support **Angular 19** as the minimum version. `NgFor` has been replaced with Angular’s native control flow (`@for (...)`). Values have been updated to be signal-based, since signals serve as the communication protocol between components and views in Angular. They automatically trigger change detection when their values change.
@arturovt I will definitely look into this and address it as soon as I have an available time window. Thank you very much for the PR! |
@arturovt Well, this looks very good so far, except for testing. I tried to find some quick fix, but failed. After all my local attempts I got stuck with the same error as on CI:
What do you think, can we make it work? |
…the core project) and related testing infrastructure
Welcoming the arrival of v4: https://github.com/dhilt/ngx-ui-scroll/releases/tag/v4.0.0 |
Note: This commit contains breaking changes, as we now support Angular 19 as the minimum version.
NgFor
has been replaced with Angular’s native control flow (@for (...)
). Values have been updated to be signal-based, since signals serve as the communication protocol between components and views in Angular. They automatically trigger change detection when their values change.