Skip to content

refactor: upgrade to Angular 19 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 25, 2025
Merged

Conversation

arturovt
Copy link
Contributor

@arturovt arturovt commented Apr 4, 2025

Note: This commit contains breaking changes, as we now support Angular 19 as the minimum version.

NgFor has been replaced with Angular’s native control flow (@for (...)). Values have been updated to be signal-based, since signals serve as the communication protocol between components and views in Angular. They automatically trigger change detection when their values change.

**Note:** This commit contains breaking changes, as we now support **Angular 19** as the minimum version.

`NgFor` has been replaced with Angular’s native control flow (`@for (...)`). Values have been updated to be signal-based, since signals serve as the communication protocol between components and views in Angular. They automatically trigger change detection when their values change.
@dhilt
Copy link
Owner

dhilt commented Apr 7, 2025

@arturovt I will definitely look into this and address it as soon as I have an available time window. Thank you very much for the PR!

@dhilt
Copy link
Owner

dhilt commented Apr 11, 2025

@arturovt Well, this looks very good so far, except for testing. I tried to find some quick fix, but failed. After all my local attempts I got stuck with the same error as on CI:

  An error was thrown in afterAll
  Error: Errors during JIT compilation of template for UiScrollComponent: Unexpected character "EOF" (Do you have an unescaped "{" in your template? Use "{{ '{' }}") to escape it.) ("
  </div>
  }
  <div data-padding-forward></div>[ERROR ->]"): ng:///UiScrollComponent/template.html@18:32, Invalid ICU message. Missing '}'. ("
  </div>
  }
  <div data-padding-forward></div>[ERROR ->]"): ng:///UiScrollComponent/template.html@18:32

What do you think, can we make it work?

@dhilt dhilt merged commit 366161e into dhilt:master Apr 25, 2025
2 checks passed
@arturovt arturovt deleted the refactor/angular-19 branch April 25, 2025 18:09
@dhilt
Copy link
Owner

dhilt commented Apr 25, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants