Skip to content

Conversation

@richardkiss
Copy link
Contributor

I found the documentation didn't quite match what I needed to do to get this to work.

Copy link
Owner

@dholth dholth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dholth dholth merged commit 8a63d64 into dholth:main May 2, 2024
@richardkiss
Copy link
Contributor Author

@dholth I'm looking at this again now, and I'm thinking that this is probably a bug in code somewhere rather than a bug in documentation. But looking at the enscons code briefly, I can't figure out where these keys are being read.

@dholth
Copy link
Owner

dholth commented May 6, 2024

https://github.com/dholth/enscons/blob/main/enscons/__init__.py#L486
https://github.com/dholth/enscons/blob/main/enscons/api.py#L49-L51
oops, that's for editable installs...

Here it is https://github.com/dholth/enscons/blob/main/enscons/__init__.py#L162-L183

It looks like the user's SConstruct is meant to parse pyproject.toml, and pass the entire project dict to enscons as metadata. Then project['scripts'] gets parsed out to create entry_points.txt. If you put all the metadata in [tool.enscons] including name, description, version then SConstruct could also pass that to enscons since the user SConstruct, not enscons itself parses toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants