Fix Emscripten build, with support for mods and Hellfire#8583
Merged
Conversation
This was preventing the Emscripten build from working on a fresh master pull
glebm
reviewed
Jun 10, 2026
| -lidbfs.js | ||
| --shell-file ${CMAKE_CURRENT_SOURCE_DIR}/Packaging/emscripten/index.html | ||
| ) | ||
| if(TARGET hellfire_copied_assets) |
Collaborator
There was a problem hiding this comment.
Is this if necessary? I think the target should always be there?
Contributor
Author
There was a problem hiding this comment.
Good call, I'll remove that this morning
glebm
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are what I had to do to get Emscripten to compile/build, as well as get Hellfire working on it, as before it didn't account for mods so it wouldn't do anything with the Hellfire .mpq files