Skip to content

Conversation

@diegohaz
Copy link
Owner

This PR adds the possibility to set the webpack publicPath config and react-router basename on build by just running PUBLIC_PATH=foo npm run build.

This is necessary to run the project on URLs like https://diegohaz.github.io/foo

@codecov-io
Copy link

codecov-io commented Feb 13, 2017

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #97   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          39     39           
  Lines         257    257           
  Branches       51     51           
=====================================
  Hits          257    257

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2104e...5df6912. Read the comment docs.

@diegohaz diegohaz merged commit b712e93 into master Feb 13, 2017
@diegohaz diegohaz deleted the set-public-path-on-build branch February 13, 2017 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants