Skip to content

Conversation

@sgrif
Copy link
Member

@sgrif sgrif commented May 22, 2018

This was already true, as we require
rust-lang/rust#46094 to compile. This commit
ensures that we test for this on CI so we know if this changes in the
future.

This was already true, as we require
rust-lang/rust#46094 to compile. This commit
ensures that we test for this on CI so we know if this changes in the
future.
@sgrif sgrif requested a review from a team May 22, 2018 16:28
- (cd diesel_cli && travis-cargo test -- --no-default-features --features "sqlite-bundled")
- rust: 1.24.1
env:
- ENSURE_SUPPORTED_RUST_VERSION=1.24.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this do anything ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puts a nice label in the matrix so it's clear what this does

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh 👍

@sgrif sgrif merged commit f5d3ab4 into master May 22, 2018
@sgrif sgrif deleted the sg-min-rust-version branch May 22, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants