-
Notifications
You must be signed in to change notification settings - Fork 277
Add github action to create PR against homebrew-core on release #5468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action to create PR against homebrew-core on release #5468
Conversation
hannes-steffenhagen-diffblue
commented
Aug 20, 2020
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
Codecov Report
@@ Coverage Diff @@
## develop #5468 +/- ##
========================================
Coverage 68.25% 68.25%
========================================
Files 1180 1180
Lines 97722 97722
========================================
Hits 66698 66698
Misses 31024 31024
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #5468 +/- ##
========================================
Coverage 68.25% 68.25%
========================================
Files 1180 1180
Lines 97722 97722
========================================
Hits 66698 66698
Misses 31024 31024
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hannes-steffenhagen-diffblue There's a conflict though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on GitHub actions or Homebrew mechanics - but all looks sensible to me.
65806df
to
65948f8
Compare