-
Notifications
You must be signed in to change notification settings - Fork 201
Add feature to throw error when unmapped elements are dropped during processing #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Partially supported with Still need something for |
Specifically, when converting to RDF, relative URIs are dropped and this should be handled by another map or similar mechanism. |
Previously: we weren't dropping undefined terms from RDFs. Fix: changed normalization aproach through json-gold library so that it returns parsing error whenever invalid data found in dataset. Added error handling logic for invalid RDF data errors where aries json ld processor is going to remove the invalid data from dataset and try again recursively. (Following digitalbazaar/jsonld.js#199) closes hyperledger-aries#1592 Signed-off-by: sudesh.shetty <[email protected]>
Previously: we weren't dropping undefined terms from RDFs. Fix: changed normalization aproach through json-gold library so that it returns parsing error whenever invalid data found in dataset. Added error handling logic for invalid RDF data errors where aries json ld processor is going to remove the invalid data from dataset and try again recursively. (Following digitalbazaar/jsonld.js#199) closes hyperledger-aries#1592 Signed-off-by: sudesh.shetty <[email protected]>
Previously: we weren't dropping undefined terms from RDFs. Fix: changed normalization aproach through json-gold library so that it returns parsing error whenever invalid data found in dataset. Added error handling logic for invalid RDF data errors where aries json ld processor is going to remove the invalid data from dataset and try again recursively. (Following digitalbazaar/jsonld.js#199) closes hyperledger-aries#1592 Signed-off-by: sudesh.shetty <[email protected]>
Previously: we weren't dropping undefined terms from RDFs. Fix: changed normalization aproach through json-gold library so that it returns parsing error whenever invalid data found in dataset. Added error handling logic for invalid RDF data errors where aries json ld processor is going to remove the invalid data from dataset and try again recursively. (Following digitalbazaar/jsonld.js#199) closes hyperledger-aries#1592 Signed-off-by: sudesh.shetty <[email protected]>
Previously: we weren't dropping undefined terms from RDFs. Fix: changed normalization aproach through json-gold library so that it returns parsing error whenever invalid data found in dataset. Added error handling logic for invalid RDF data errors where aries json ld processor is going to remove the invalid data from dataset and try again recursively. (Following digitalbazaar/jsonld.js#199) closes hyperledger-aries#1592 Signed-off-by: sudesh.shetty <[email protected]>
@dlongley I want to make this explode, whats the easiest way to do that? I have this PR with a failing test: transmute-industries/vc.js#26 |
Sorry, just seeing this now, a month later. Using an undefined |
explode means that when someone hands json that has been mutated after being signed, a verifier will throw an error on it, not return "verified". |
When certain elements in a document cannot be mapped to absolute URLs (via
@context
or a base URL), then are silently dropped during expansion per the spec. There should be a feature in this processor that, instead, causes an error to be raised. This is particularly important when this library is used in conjunction with digital signing libraries.Related to #178.
The text was updated successfully, but these errors were encountered: