-
Notifications
You must be signed in to change notification settings - Fork 84
Fix app not working in Chrome when served from a filesystem #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix app not working in Chrome when served from a filesystem #75
Conversation
…uations. If we can't use it, at least get out of the way so the rest of the app can function.
Fix app not working in Chrome when served from a filesystem
|
This is great. But Chrome still doesn't allow file:// based ajax either, so the app still fires the warning to open Chrome with |
|
Yes, you're correct. I had an old session open that I started with that flag and hence forgot about it. But we could use JSONP to solve that problem. |
|
I wish we could. But you can't really make JSONP work with local files On Fri, Sep 4, 2015 at 8:29 AM, Timothy Farrell [email protected]
John Dyer - http://j.hn/ |
|
But we do have control over the generated files. It's a matter of deciding what our function name is and statically using that one when we generate files. This is a bit of a hacky solution but would work. If this is an acceptable solution, I would rather decide that the JSONP function name be |
|
I would SOOOO love to do that. However, part of the original app requirements were to have the chapters be I've been searching for a solution to this for some time, so if you can On Mon, Sep 7, 2015 at 2:27 PM, Timothy Farrell [email protected]
John Dyer - http://j.hn/ |
|
Can you give me some more ideas about what is a "lower powered, slower device"? You're already parsing the HTML as a string in Javascript (with jQuery here: https://github.com/digitalbiblesociety/browserbible-3/blob/master/app/js/texts/textprovider-local.js#L85) so the AMD method shouldn't add considerable overhead over what you already have. In case I've missed something in reading the source above, the only option left is use iframes but that might run astray of the scroll controller. |
|
Oh sorry I missed the "functional static" part. Could we have the content in two files (html and JS string) for two separate modes since the static site is already a separate mode until itself? |
This partially addresses #71. The point here is to prevent localStorage failure from disabling the whole application. This allows Chrome to at least be used when viewing from a file:// even if settings are not preserved across sessions.