Skip to content

Export page access statistics#3394

Draft
jarlhengstmengel wants to merge 4 commits intodevelopfrom
feature/export_page_access_statistics
Draft

Export page access statistics#3394
jarlhengstmengel wants to merge 4 commits intodevelopfrom
feature/export_page_access_statistics

Conversation

@jarlhengstmengel
Copy link
Copy Markdown
Contributor

Short description

This PR adds the download function for page access statistics

Proposed changes

  • Download functionality on the statistics page is extended to be able to select which statistics should be downloaded
  • Page Statistics can be downloaded as csv
  • For that updatePageAccessesin statistics-page-accesses.ts is extended to create an array with the page statistics data and a method exportPageAccessesData is introduced

Side effects

Resolved issues

Fixes: #3134


Pull Request Review Guidelines

@jarlhengstmengel jarlhengstmengel added the blocked Blocked by external dependency label Feb 4, 2025
@jarlhengstmengel jarlhengstmengel marked this pull request as draft March 21, 2025 10:05
@jarlhengstmengel jarlhengstmengel force-pushed the feature/export_page_access_statistics branch 2 times, most recently from bf84fed to 563ba68 Compare April 10, 2025 17:33
@jarlhengstmengel jarlhengstmengel removed the blocked Blocked by external dependency label Apr 17, 2025
@jarlhengstmengel jarlhengstmengel added the blocked Blocked by external dependency label Apr 30, 2025
@jarlhengstmengel jarlhengstmengel force-pushed the feature/export_page_access_statistics branch from 563ba68 to 365c709 Compare January 21, 2026 16:39
@jarlhengstmengel
Copy link
Copy Markdown
Contributor Author

jarlhengstmengel commented Jan 21, 2026

It's alive 🥳 Not even one year stale :D

@jarlhengstmengel jarlhengstmengel removed the blocked Blocked by external dependency label Jan 21, 2026
@jarlhengstmengel
Copy link
Copy Markdown
Contributor Author

I concluded that it makes sense to wait for #4088 before working further on this

@jarlhengstmengel jarlhengstmengel added the blocked Blocked by external dependency label Jan 22, 2026
@dkehne
Copy link
Copy Markdown
Collaborator

dkehne commented Jan 26, 2026

Blocker Analysis

PR Status Actually blocking?
#3325 Merged (April 2025) ❌ No longer relevant
#4088 Open ❌ No code dependency

#3394 and #4088 are independent - they both modify statistics-page-accesses.ts but touch different parts:

They can be merged in any order with merge conflict resolution.


What needs to be fixed

1. Rebase onto current develop

The branch is based on old code from before #3325 was merged. Rebase to get current state:

git fetch origin
git rebase origin/develop

2. Update PR description

Remove the outdated "blocked by #3325" reference since it merged 9 months ago.

3. Fix failing CI

The develop CircleCI check is failing - needs investigation after rebase.

4. Consider interaction with #4088 (if it merges first)

With #4088, collapsing/expanding pages changes the displayed totals (parent shows sum of children when collapsed). However, exportTable is only populated once when data is fetched - it won't reflect changes from toggle operations.

Options:

  • Simple: Document that export shows raw per-page data regardless of collapse state
  • Better: Regenerate export data at export time from DOM data-accesses attributes (which Fix inconsistent page accesses #4088 adds)
  • Alternative: Update exportTable when calculateToggleSubpages() runs

Note: This review was done with AI assistance (Claude Code).

@jarlhengstmengel
Copy link
Copy Markdown
Contributor Author

* **Better:** Regenerate export data at export time from DOM `data-accesses` attributes (which [Fix inconsistent page accesses #4088](https://github.com/digitalfabrik/integreat-cms/pull/4088) adds)

This is the plan and the reason I added the blocker last week. The suggested rebase already happened last week. The blocker label here marks for myself and others who might be interested that further work is on hold to avoid implementing similar things twice and to prevent diffcult merges. The description I didn't change since this is still work in progress and not all requirements are met yet.

@dkehne
Copy link
Copy Markdown
Collaborator

dkehne commented Jan 27, 2026

Okay, i couldn't maybe judge what a "diffcult merge" might be. thought it's touching different areas and the blocking-label seems to me as a "slowing down"-marker.

@jarlhengstmengel
Copy link
Copy Markdown
Contributor Author

In this case I'm waiting for some attributes #4088 is introducing. Theoreticly I could branch of from the branch that #4088 wants to merge into develop, but in the current planning, the priority isn't high enough compared to #4088 and for example the push notifacation translation. Branching off could possibly mean more work rebasing/merging, depending on the reviews for #4088. So I decided to avoid that risk and work on more pressing things and continue with this after #4088 is merged. So the blocked-label is more a "this is waiting on another Issue to be fixed, but next steps are clear" label. The blocking-label on the other hand would mean here is a bottle neck and another Issue is waiting for this.

@osmers osmers added this to the Next milestone Mar 17, 2026
@jarlhengstmengel jarlhengstmengel removed this from the Next milestone Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Blocked by external dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust export for page access statistics

3 participants