Making isOpen = false more accurate after closing a modal#1006
Open
patri-badger wants to merge 1 commit into
Open
Making isOpen = false more accurate after closing a modal#1006patri-badger wants to merge 1 commit into
patri-badger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an issue in the project I'm working on. We closed the modal and a backend process was so fast that when we tried to open again the modal it opened it and closed it immediately (invisible to us) because the setTimeout in close finished after we opened the new modal. This provoked our app inaccesible in the places the modal was shown. Typing in console isOpen it said true.
We were checking before opening the modal isOpen but it had false and we tried to open a new modal. With this change isOpen will be false when it has really close the modal. I hope you like this solution.