Prevent setting alt=String("undefined") when the original IMG has no alt#1049
Open
jaydansand wants to merge 1 commit into
Open
Prevent setting alt=String("undefined") when the original IMG has no alt#1049jaydansand wants to merge 1 commit into
jaydansand wants to merge 1 commit into
Conversation
pilafmon
reviewed
Dec 6, 2018
| var img = document.createElement('img'); | ||
| img.className = 'mfp-img'; | ||
| if(item.el && item.el.find('img').length) { | ||
| img.alt = item.el.find('img').attr('alt'); |
There was a problem hiding this comment.
Rather than an if statement with mostly duplicate lines, cleaner to tack on || '':
img.alt = item.el.find('img').attr('alt') || '';
Author
There was a problem hiding this comment.
Sure! I guess I'm always leery of depending on truthiness in loose-typed languages. Maybe because I'm too accustomed to PHP's terrible string finagling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #871, when using the Image type and the
<img>has noaltattribute, Magnific Popup's image.js on line 193 will erroneously replace the image with a newimgwherealt=String("undefined").Problem line in Magnific Popup code (image.js:193):
img.alt = item.el.find('img').attr('alt');Problem description:
As of jQuery version 1.6 (and Magnific Popup requires > 1.6)
jQuery.attr()returnsundefinedif the attribute does not exist. When settingimg.alt = undefined, undefined is converted to a String and the actual text "undefined" gets assigned.Proof of Underlying Problem (in jQuery):
Solution/Fix:
Test
item.el.find('img').attr('alt')before assigningimg.alt, as done in this PR.