Sanitise attributes with jQuery#770
Merged
Merged
Conversation
Contributor
|
Looks nicer too :) |
dimsemenov
added a commit
that referenced
this pull request
Feb 20, 2016
Sanitize attributes with jQuery when replacing img element
This was referenced Jul 1, 2024
This was referenced Jul 8, 2024
This was referenced Aug 27, 2024
This was referenced Sep 3, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to use this library on Wordpress VIP it has to pass through their security checks. They highlighted the use of unsanitised variables in the creation of the img element on line 783 of core.js as a problem that prevented us from using the code. This fix was what allowed me to deploy it.