Skip to content

[URP-306] - Updating The User Authorisation On The Web Api Layer #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SmithR-IS merged 1 commit into from
Jul 17, 2026
Merged

[URP-306] - Updating The User Authorisation On The Web Api Layer #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/src/Controllers/UserController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ CancellationToken cancellationToken
error switch
{
GetUsersError.OrganisationNotFound => BadRequest("Organisation not found."),
GetUsersError.NotAllowed => Forbid("User is forbidden from accessing data."),
_ => throw new UnreachableException("Unhandled GetUsersError variant."),
}
);
Expand Down
26 changes: 26 additions & 0 deletions backend/tests/Controllers/UserControllerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,32 @@ public async Task GetUsers_ReturnsNotFound_WhenOrganisationDoesNotExist()
badRequest.Value.ShouldBe("Organisation not found.");
}

[Fact]
public async Task GetUsers_ReturnsForbid_WhenNotAllowed()
{
var sampleId = 1;
_mockUserService
.GetUsers(
Arg.Any<int?>(),
Arg.Any<int>(),
Arg.Any<int>(),
Arg.Any<IReadOnlyCollection<UserOrgStatus>>(),
TestContext.Current.CancellationToken
)
.Returns(
Result<PaginatedResponseDto<UserListItemDto>, GetUsersError>.Err(
new GetUsersError.NotAllowed(sampleId)
)
);

ActionResult<PaginatedResponseDto<UserListItemDto>> result = await _controller.GetUsers(
CreateQuery(),
TestContext.Current.CancellationToken
);

result.Result.ShouldBeOfType<ForbidResult>();
}

[Fact]
public async Task GetUsers_ReturnsBadRequest_WhenQueryIsNull()
{
Expand Down