Skip to content

[Bug] Toolbar handle can go out of window #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rafaelurben opened this issue May 14, 2021 · 3 comments
Closed

[Bug] Toolbar handle can go out of window #1471

rafaelurben opened this issue May 14, 2021 · 3 comments

Comments

@rafaelurben
Copy link

When changing from a bigger to a smaller screen, it can happen that the toolbar is out of the screen and therefore not clickable. It can be brought back by zooming out and moving the handle, but I think this shouldn't happen.

@matthiask
Copy link
Member

@rafaelurben Thanks for the report. This has bothered me a few times too.

Do you want to attempt fixing this? Search toolbar.js for djdt.top. Things should be fixed after reloading but handling resize events on the window object would certainly be a good idea. Here's the code which handles the positioning on page load (I think): https://github.com/jazzband/django-debug-toolbar/blob/4e3d12f8581cc269cbfc7e912124746947da1d07/debug_toolbar/static/debug_toolbar/js/toolbar.js#L221-L228 . djdt.top isn't updated in the local storage on page load either so I think it's fine to skip this in the resize handler too.

@rafaelurben
Copy link
Author

I'm sorry but I don't really have the time, setup and knowledge to fix this at the moment. 😞

@matthiask
Copy link
Member

That's fine, this report motivated me to submit a pull request myself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants