Additional readme warning when using docker

[daniel-butler]

https://gist.github.com/douglasmiranda/9de51aaba14543851ca3#file-option2-py

[codecov]

Codecov Report

Merging #1294 (708e700) into main (3ed59cb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1294   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files          35       35           
  Lines        1864     1864           
  Branches      262      262           
=======================================
  Hits         1614     1614           
  Misses        178      178           
  Partials       72       72           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed59cb...708e700. Read the comment docs.

[matthiask]

I also like this option (obviously) https://stackoverflow.com/a/49818040/317346

if DEBUG:
    # `debug` is only True in templates if the vistor IP is in INTERNAL_IPS.
    INTERNAL_IPS = type(str('c'), (), {'__contains__': lambda *a: True})()

[daniel-butler]

That works too! I didn't see that stack overflow Q/A

[tim-schilling]

Is there a functional difference between your suggestion @matthiask and setting SHOW_TOOLBAR_CALLBACK to the following function:

def show_toolbar(request):
    return settings.DEBUG

If the INTERNAL_IPS is configured to be a pass-through, then the only thing the default callback does is check DEBUG.

[matthiask]

Is there a functional difference between your suggestion @matthiask and setting SHOW_TOOLBAR_CALLBACK to the following function:

def show_toolbar(request):
    return settings.DEBUG

If the INTERNAL_IPS is configured to be a pass-through, then the only thing the default callback does is check DEBUG.

I don't think there's a difference for django-debug-toolbar. Maybe Django itself does some things differently when INTERNAL_IPS matches. TBH I don't remember why I went with this type(...)() thing mentioned above – it probably worked well enough to be carried from project to project.