Skip to content

Show template context on included templates #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gilmrjc
Copy link
Contributor

@gilmrjc gilmrjc commented Jan 20, 2021

This PR makes possible to see the template context of a nested template on the SQL panel.

Fix #902

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #1436 (3b5f910) into main (cdb6b7e) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
- Coverage   86.38%   86.34%   -0.04%     
==========================================
  Files          35       35              
  Lines        1851     1853       +2     
  Branches      259      260       +1     
==========================================
+ Hits         1599     1600       +1     
- Misses        179      181       +2     
+ Partials       73       72       -1     
Impacted Files Coverage Δ
debug_toolbar/panels/history/panel.py 89.79% <ø> (ø)
debug_toolbar/utils.py 76.47% <100.00%> (+0.31%) ⬆️
debug_toolbar/panels/profiling.py 88.39% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb6b7e...3b5f910. Read the comment docs.

@gilmrjc gilmrjc force-pushed the display-sql-context-in-nested-templates branch from d9ce6f5 to 6c38723 Compare January 20, 2021 12:44
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check the sqlite failures?

@matthiask
Copy link
Member

The test failures are probably related to #1427

They are not related to sqlite3 – the problems appear in the sqlite3 build only because sqlite3 is the only build which runs tests using Django@master.

@gilmrjc gilmrjc force-pushed the display-sql-context-in-nested-templates branch from 6c38723 to 6545565 Compare January 20, 2021 15:52
@gilmrjc gilmrjc requested a review from auvipy January 20, 2021 15:55
Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I ran this locally with some changes to the example app.

Base automatically changed from master to main February 11, 2021 15:01
@gilmrjc gilmrjc force-pushed the display-sql-context-in-nested-templates branch from 6545565 to f527947 Compare May 9, 2021 07:10
@gilmrjc
Copy link
Contributor Author

gilmrjc commented May 9, 2021

I rebased the branch to include the new changes.

@matthiask
Copy link
Member

Thanks!

@gilmrjc gilmrjc deleted the display-sql-context-in-nested-templates branch May 9, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL panel points a query in an included template to the same line of its parent template
4 participants