-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support JS events when loading a panel. #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JS events when loading a panel. #1441
Conversation
This fixes the problem of the Timer Panel not inserting the browser timings section after being loaded via the HistoryPanel. These events could be wired into to better render panels or support a more dynamic toolbar and/or panel.
I think I like it. @jdufresne I requested a review because you added the new panel loading code; please feel free to skip this if you don't find the time or energy for a review! |
I was thinking more about this and I'm going to make a single event with a
property that contains the panel id. It makes more sense than the event
being the panel id. I can create a public function that does the boiler
plater listener logic that does the basic filtering. It seems cleaner in my
mind.
|
This fixes the problem of the Timer Panel not inserting the browser timings section after being loaded via the HistoryPanel. These events could be wired into to better render panels or support a more dynamic toolbar and/or panel.
Codecov Report
@@ Coverage Diff @@
## main #1441 +/- ##
==========================================
+ Coverage 86.33% 86.50% +0.16%
==========================================
Files 34 34
Lines 1852 1852
Branches 260 260
==========================================
+ Hits 1599 1602 +3
+ Misses 181 178 -3
Partials 72 72
Continue to review full report at Codecov.
|
I changed the approach to put the responsibility of handling the async nature of a panel's scripts on the panel's script rather than These commits should be squashed before merging (if approved). |
This looks good I think. @tim-schilling Do you think it's ready to merge or is there anything left to do here? |
Thanks for the reviews folks. Squashed and merged in. |
This fixes the problem of the Timer Panel not inserting the browser
timings section after being loaded via the HistoryPanel.
These events could be wired into to better render panels or support
a more dynamic toolbar and/or panel.
Fixes #1439