Skip to content

Drop support for Django 3.0. #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2021

Conversation

hramezani
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #1461 (e0b1332) into main (8b280e1) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1461      +/-   ##
==========================================
+ Coverage   86.50%   86.60%   +0.10%     
==========================================
  Files          34       34              
  Lines        1852     1852              
  Branches      260      260              
==========================================
+ Hits         1602     1604       +2     
+ Misses        178      177       -1     
+ Partials       72       71       -1     
Impacted Files Coverage Δ
debug_toolbar/panels/signals.py 86.36% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b280e1...e0b1332. Read the comment docs.

@matthiask
Copy link
Member

Thanks! Do you have any idea where the coverage decrease comes from? We cannot drop backwards compatibility shims yet because of 2.2, I'm a bit surprised that it changed anything...

@hramezani
Copy link
Contributor Author

Thanks! Do you have any idea where the coverage decrease comes from?

I don't know exactly. based on the report it comes from debug_toolbar/panels/profiling.py lines 64,66,68 which seems weird to me.
After I pushed another commit it passed successfully 🤷‍♂️

@hramezani
Copy link
Contributor Author

We cannot drop backwards compatibility shims yet because of 2.2, I'm a bit surprised that it changed anything...

The 3.0.x series no longer receive security updates or bug fixes.

@matthiask
Copy link
Member

The 3.0.x series no longer receive security updates or bug fixes.

Yes, but since we still support the older 2.2 series we cannot drop any backwards compatibility code yet.

Still, let's merge this since faster CI runs are good (tm).

@matthiask matthiask merged commit e8c9036 into django-commons:main Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants