Skip to content

Update translations and revert xgettext aliasing. #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

tim-schilling
Copy link
Member

Aliasing xgettext causes the usage not to be picked up by makemessages.
Only gettext and gettext_lazy work with aliasing.

Aliasing xgettext causes the usage not to be picked up by makemessages.
Only gettext and gettext_lazy work with aliasing.
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #1494 (fa868cc) into main (f65d86b) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
+ Coverage   86.58%   86.69%   +0.10%     
==========================================
  Files          35       35              
  Lines        1864     1864              
  Branches      262      262              
==========================================
+ Hits         1614     1616       +2     
+ Misses        178      177       -1     
+ Partials       72       71       -1     
Impacted Files Coverage Δ
debug_toolbar/panels/cache.py 82.26% <100.00%> (ø)
debug_toolbar/panels/logging.py 95.91% <100.00%> (ø)
debug_toolbar/panels/signals.py 86.36% <100.00%> (ø)
debug_toolbar/panels/sql/panel.py 67.68% <100.00%> (ø)
debug_toolbar/panels/staticfiles.py 95.53% <100.00%> (ø)
debug_toolbar/panels/profiling.py 91.07% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65d86b...fa868cc. Read the comment docs.

@matthiask matthiask merged commit 3ed59cb into main Aug 14, 2021
@matthiask matthiask deleted the update-translations branch August 14, 2021 15:42
@matthiask
Copy link
Member

Great find!

@tim-schilling
Copy link
Member Author

tim-schilling commented Aug 14, 2021 via email

@matthiask
Copy link
Member

Good question ... :-/

@tim-schilling
Copy link
Member Author

I suspect transifex does do notifications, but probably a good idea to solicit for some help.

@tim-schilling
Copy link
Member Author

Notifications for folks who have submitted translations in the past*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants