Skip to content

Run CI tests weekly. #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Run CI tests weekly. #1523

merged 1 commit into from
Nov 4, 2021

Conversation

tim-schilling
Copy link
Member

This helps identify issues with the library as
django and other dependencies release new versions.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #1523 (92ccb26) into main (e139c6f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1523   +/-   ##
=======================================
  Coverage   85.87%   85.87%           
=======================================
  Files          35       35           
  Lines        1883     1883           
  Branches      274      274           
=======================================
  Hits         1617     1617           
  Misses        187      187           
  Partials       79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e139c6f...92ccb26. Read the comment docs.

Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an excellent idea! The MySQL failures are definitely unrelated, something changed in the Django@main version...

(If you wanted to avoid too much load on Github you could switch to a weekly schedule but it probably doesn't make a big difference.)

@tim-schilling
Copy link
Member Author

The MySQL failures are definitely unrelated, something changed in the Django@main version

Interestingly enough, that integration issue is exactly what this change is supposed to identify.

If you wanted to avoid too much load on Github you could switch to a weekly schedule but it probably doesn't make a big difference.

I added that because in the GitHub Actions documentation for schedule, it mentions that. I could be persuaded to drop down to weekly.

It'd be ideal if we could schedule this to run when any of the tox dependencies has a release, but I'm not sure if that's really possible.

This helps identify issues with the library as
django and other dependencies release new versions.
@tim-schilling tim-schilling changed the title Run CI tests daily. Run CI tests weekly. Nov 4, 2021
@tim-schilling
Copy link
Member Author

I did a quick look on the interwebs for a way to trigger based on other packages releases, but the best option is dependabot. I think we could do this, but I'll open an issue for discussion.

@tim-schilling
Copy link
Member Author

I also changed this to run weekly. It's more environmentally friendly and frankly we likely won't be fixing integration issues the day after the crop up.

@tim-schilling tim-schilling merged commit e4b4529 into django-commons:main Nov 4, 2021
@tim-schilling tim-schilling deleted the run-ci-daily branch November 4, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants