Skip to content

Drop support for Django 3.1 #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Conversation

hramezani
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #1548 (57ca083) into main (9ec7210) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1548      +/-   ##
==========================================
- Coverage   85.97%   85.87%   -0.11%     
==========================================
  Files          36       36              
  Lines        1883     1883              
  Branches      310      310              
==========================================
- Hits         1619     1617       -2     
- Misses        186      187       +1     
- Partials       78       79       +1     
Impacted Files Coverage Δ
debug_toolbar/panels/profiling.py 88.54% <0.00%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ec7210...57ca083. Read the comment docs.

@pauloxnet
Copy link
Member

Coverage seems decreased maybe some code specific for django 3.1 are not used anymore ?

@tim-schilling
Copy link
Member

The codecov percentage is flaky. We're likely to drop it as per #1542

@tim-schilling
Copy link
Member

Let me v3.2.4 out the door and I'll merge this.

Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could even drop Django 2.2, at least soon.

django-upgrade may help with dropping old code afterwards.

@pauloxnet
Copy link
Member

"I think we could even drop Django 2.2, at least soon."

Not before April 2022 https://www.djangoproject.com/download/#supported-versions

@hramezani
Copy link
Contributor Author

I think we can drop support for Django < 3.2. Here is a comment from Tim about this jazzband/django-hosts#141 (comment)

@pauloxnet
Copy link
Member

pauloxnet commented Dec 16, 2021

No, once Django 4.0 is out, it's time to drop support for all versions older than the most recent LTS. Otherwise, it could require ugly shims to add 4.0 support (which removes a lot of deprecated things). This is outlined in https://www.djangoproject.com/weblog/2015/jun/25/roadmap/.

Thanks for pointing to this @timgraham explanation. 👍

@matthiask matthiask merged commit 1964826 into django-commons:main Dec 16, 2021
@hramezani hramezani deleted the drop_django31 branch December 16, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants