-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Drop support for Django 3.1 #1548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1548 +/- ##
==========================================
- Coverage 85.97% 85.87% -0.11%
==========================================
Files 36 36
Lines 1883 1883
Branches 310 310
==========================================
- Hits 1619 1617 -2
- Misses 186 187 +1
- Partials 78 79 +1
Continue to review full report at Codecov.
|
Coverage seems decreased maybe some code specific for django 3.1 are not used anymore ? |
The codecov percentage is flaky. We're likely to drop it as per #1542 |
Let me v3.2.4 out the door and I'll merge this. |
16eceac
to
165d5ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could even drop Django 2.2, at least soon.
django-upgrade may help with dropping old code afterwards.
Not before April 2022 https://www.djangoproject.com/download/#supported-versions |
I think we can drop support for Django < 3.2. Here is a comment from Tim about this jazzband/django-hosts#141 (comment) |
Thanks for pointing to this @timgraham explanation. 👍 |
No description provided.