Fix USE_TZ RemovedInDjango50Warning #1573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay looks like the test suite needs adjustment... |
adamchainz
commented
Jan 12, 2022
Comment on lines
-124
to
+130
| list(User.objects.filter(date_joined=datetime.datetime(2017, 12, 22, 16, 7, 1))) | ||
| list( | ||
| User.objects.filter( | ||
| date_joined=datetime.datetime( | ||
| 2017, 12, 22, 16, 7, 1, tzinfo=datetime.timezone.utc | ||
| ) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
change from naive datetime, which django will interpret with the default timezone, to aware
|
|
||
| DATA = {"value": "foo", "date": datetime(2020, 1, 1)} | ||
| SIGNED_DATA = f'{{"date": "2020-01-01 00:00:00", "value": "foo"}}:{SIGNATURE}' | ||
| DATA = {"value": "foo", "date": datetime(2020, 1, 1, tzinfo=timezone.utc)} |
There was a problem hiding this comment.
Again, this changes the naive datetime to aware, so that it isn't interpreted with the default timezone when converting to str
adamchainz
commented
Jan 12, 2022
Comment on lines
+145
to
+149
| if connection.vendor == "postgresql": | ||
| # PostgreSQL always includes timezone | ||
| expected_datetime = '["2017-12-22 16:07:01+00:00"]' | ||
| else: | ||
| expected_datetime = '["2017-12-22 16:07:01"]' |
There was a problem hiding this comment.
new formatting difference being triggered on PostgreSQL
Fix this warning, which appears in both the docs build and Django 4.0 tests: ``` /.../python3.8/site-packages/django/conf/__init__.py:199: RemovedInDjango50Warning: The default value of USE_TZ will change from False to True in Django 5.0. Set USE_TZ to False in your project settings if you want to keep the current default behavior. ```
|
Very nice, thanks! |
gone
pushed a commit
to gone/django-debug-toolbar
that referenced
this pull request
Jan 16, 2022
Fix this warning, which appears in both the docs build and Django 4.0 tests: ``` /.../python3.8/site-packages/django/conf/__init__.py:199: RemovedInDjango50Warning: The default value of USE_TZ will change from False to True in Django 5.0. Set USE_TZ to False in your project settings if you want to keep the current default behavior. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this warning, which appears in both the docs build and Django 4.0 tests: