Optimize SQL reformatting #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After #1571 is merged, I'd like to rebase this and update the release note. |
Add a few bits of caching: 1. Add sub-function to `parse_sql` with `lru_cache`, so that repeat calls with the same query are fast. This saves a lot of processing in N+1 situations. 2. Cache constructed filter stacks in `get_filter_stack()`. This avoids recreating all the various sqlparse objects for each query. 3. Pre-compile the simplification regex. The `re` module already uses an internal LRU cache of regexes, but this avoids recompiling if the regex ever drops out of that cache. Building on top of django-commons#1571, this takes run time for the same tested view from ~1100ms to ~950ms, another ~15% saving.
adamchainz
force-pushed
the
optimize_sql_panel_2
branch
from
0c19469 to
64d9295
Compare
|
Rebased and updated |
|
Thanks! That's awesome. |
gone
pushed a commit
to gone/django-debug-toolbar
that referenced
this pull request
Jan 16, 2022
Add a few bits of caching: 1. Add sub-function to `parse_sql` with `lru_cache`, so that repeat calls with the same query are fast. This saves a lot of processing in N+1 situations. 2. Cache constructed filter stacks in `get_filter_stack()`. This avoids recreating all the various sqlparse objects for each query. 3. Pre-compile the simplification regex. The `re` module already uses an internal LRU cache of regexes, but this avoids recompiling if the regex ever drops out of that cache. Building on top of django-commons#1571, this takes run time for the same tested view from ~1100ms to ~950ms, another ~15% saving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few bits of caching:
parse_sqlwithlru_cache, so that repeat calls with the same query are fast.This saves a lot of processing in N+1 situations.
get_filter_stack().This avoids recreating all the various sqlparse objects for each query.
The
remodule already uses an internal LRU cache of regexes, but this avoids recompiling if the regex ever drops out of that cache.Building on top of #1571, this takes run time for the same tested view from ~1100ms to ~950ms, another ~15% saving.