Minor testing cleanups #1782
Merged
Minor testing cleanups #1782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify envlist specification (no functional changes) * Tweak dj42 django dependency specification * Enable selenium tests for Python 3.11/Django 4.2 instead of for Python 3.10/Django 4.1. * Minor file formatting tweaks.
Switch from setting the options.headless attribute to calling
options.add_argument("-headless"). See [1] for more info.
[1] https://www.selenium.dev/blog/2023/headless-is-going-away/
Don't pass bytes objects as filter arguments for CharField fields. They get passed to str() internally within Django which results in a BytesWaring.
matthiask
approved these changes
May 16, 2023
| py{38,39,310}-dj32-{sqlite,postgresql,postgis,mysql} | ||
| py310-dj40-sqlite | ||
| py{310,311}-dj41-{sqlite,postgresql,postgis,mysql} | ||
| py{310,311}-dj{42,main}-{sqlite,postgresql,psycopg3,postgis,mysql} |
There was a problem hiding this comment.
Thank you for cleaning this up
| @@ -40,7 +39,7 @@ setenv = | |||
| PYTHONPATH = {toxinidir} | |||
| PYTHONWARNINGS = d | |||
| py39-dj32-postgresql: DJANGO_SELENIUM_TESTS = true | |||
| py310-dj41-postgresql: DJANGO_SELENIUM_TESTS = true | |||
| py311-dj42-postgresql: DJANGO_SELENIUM_TESTS = true | |||
| @@ -149,7 +149,7 @@ def test_non_ascii_query(self): | |||
| self.assertEqual(len(self.panel._queries), 2) | |||
|
|
|||
| # non-ASCII bytes parameters | |||
| list(User.objects.filter(username="café".encode())) | |||
| list(Binary.objects.filter(field__in=["café".encode()])) | |||
There was a problem hiding this comment.
What's the purpose behind changing this from a bytes to a list of bytes?
There was a problem hiding this comment.
I found that even with BinaryField, using .filter(field="café") would generate a BytesWarning internally within Django. Not wanting to shave that particular yak, I found that switching to the form above allowed the test to proceed without any BytesWarning.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some minor tweaks to the
tox.inifile (the only functional change is enabling selenium tests for Python 3.11/Django 4.2 instead of for Python 3.10/Django 4.1), and fix a few warnings generated by the tests.