Skip to content

Prevent unauthorized access to views #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Prevent unauthorized access to views #926

merged 1 commit into from
Mar 27, 2017

Conversation

jdufresne
Copy link
Contributor

All views in debug_toolbar are now decorated with the new
debug_toolbar.decorators.require_show_toolbar. This prevents access when
the function defined by SHOW_TOOLBAR_CALLBACK returns False. For
example, when a request originated form outside INTERNAL_IPS.

Fixes #834

All views in debug_toolbar are now decorated with the new
debug_toolbar.decorators.require_show_toolbar. This prevents access when
the function defined by SHOW_TOOLBAR_CALLBACK returns False. For
example, when a request originated form outside INTERNAL_IPS.

Fixes #834
@codecov
Copy link

codecov bot commented Mar 27, 2017

Codecov Report

Merging #926 into master will increase coverage by 5.95%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   77.11%   83.07%   +5.95%     
==========================================
  Files          30       31       +1     
  Lines        1643     1660      +17     
  Branches      245      246       +1     
==========================================
+ Hits         1267     1379     +112     
+ Misses        303      200     -103     
- Partials       73       81       +8
Impacted Files Coverage Δ
debug_toolbar/panels/templates/views.py 70.21% <100%> (+46.29%) ⬆️
debug_toolbar/views.py 78.57% <100%> (+32.41%) ⬆️
debug_toolbar/panels/sql/views.py 75.8% <100%> (+62.01%) ⬆️
debug_toolbar/decorators.py 100% <100%> (ø)
debug_toolbar/middleware.py 87.5% <80%> (+10.28%) ⬆️
debug_toolbar/toolbar.py 81.42% <0%> (+1.42%) ⬆️
debug_toolbar/panels/sql/tracking.py 81.44% <0%> (+2.06%) ⬆️
debug_toolbar/panels/staticfiles.py 91.75% <0%> (+11.34%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84cb158...68c4410. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants