Skip to content

Documented backwards incompatible change in 1.8 #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Documented backwards incompatible change in 1.8 #961

merged 1 commit into from
Sep 6, 2017

Conversation

jdufresne
Copy link
Contributor

SHOW_TOOLBAR_CALLBACK no longer returns False for AJAX requests. Custom values shouldn't either.

Fixes #954

SHOW_TOOLBAR_CALLBACK no longer returns False for AJAX requests. Custom
values shouldn't either.

Fixes #954
@codecov
Copy link

codecov bot commented Jun 29, 2017

Codecov Report

Merging #961 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #961   +/-   ##
=======================================
  Coverage   83.46%   83.46%           
=======================================
  Files          28       28           
  Lines        1578     1578           
  Branches      235      235           
=======================================
  Hits         1317     1317           
  Misses        192      192           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ddc7b...22c22d7. Read the comment docs.

@matthiask matthiask merged commit 8633cc0 into django-commons:master Sep 6, 2017
@matthiask
Copy link
Member

Thanks!

@jdufresne jdufresne deleted the doc-change branch November 13, 2017 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants