refactor: include package typing in distribution #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuroOravec
commented
Jan 26, 2025
| @@ -0,0 +1,9 @@ | |||
| # DO NOT MODIFY, ONLY UPDATE THE MODULE NAME WHEN NEEDED! | |||
There was a problem hiding this comment.
As mentioned here, this file was originally generated by maturin, but maturin skips it when it sees __init__.pyi.
It's possible that this is a bug on maturin's side that maybe it checks only for file name, but NOT for file extension. because I think __init__.pyi should NOT overwrite __init__.py.
Anyway, I thus included this file manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally I've already installed the Rust impl into django-components, and it works. But the types are not showing up for
djc-core-html-parser.This should fix it, as
py.typedand__init__.pyiare places such that they are inserted into the python package that maturin builds.