-
Notifications
You must be signed in to change notification settings - Fork 211
Support for pymongo 3 #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… projection since pymongo 3.0
…ctions are safe by default and have been since the introduction of the MongoClient in pymongo 2.4
…go built-in fixture teardown tries to delete all records from the collections, however this breaks on the capped collections.
…apped collections
…s - you can't do the seconds create. Added some data cleanup in the test setups. Made the connection args test more specific
Fixes issues mentioned in #210 |
I think this needs to be rebased since I merged in your safe writes PR. |
Can you also pull in some of the documentation updates from #208? |
Ok - will merge those into this branch. |
@ajdavis mentioned that pymongo 2.9 will be compatible with both 2.8 and 3.0, so can we standardize on that? If its too much work, I'm happy to cut a new version and require 3.0. |
Could be an option to maintain a 0.5.x branch for supporting pymongo < 3 and use 0.6.x (master) for pymongo 3 onwards. We can use pymongo >= 2.9, but i don't think some of the other changes (e.g. removing MongoReplicaSetClient in favour of MongoClient for connecting to replica sets) are being backported. @ajdavis might be able to clarify on that. Pymongo 3 still supports the old crud API (find, update, remove) so I think anyone using it directly will still be able to do pretty much everything they are doing with 2.x |
…ong pull request). pip install from tarballs
MongoReplicaSetClient lives on in 3.0 as a synonym for MongoClient, so you On Tuesday, June 23, 2015, Mark Unsworth [email protected] wrote:
|
There seems to be an issue since moving to use the nonrel-1.6 branch from nonrel-1.6-beta use to the use of Added a workaround of setting Some feedback would be useful here |
ok - we now have backwards compatibility with 2.x Have also added more configurations to the environment matrix to test against the latest 2.x and 3.x versions |
- DJANGO_VERSION=1.6 PYMONGO_VERSION=2.8.1 | ||
- DJANGO_VERSION=1.6 PYMONGO_VERSION=3.0.2 | ||
- DJANGO_VERSION=1.7 PYMONGO_VERSION=2.8.1 | ||
- DJANGO_VERSION=1.7 PYMONGO_VERSION=3.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does django 1.7 actually work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet (am planning to look at that next). I've added it to the allowable failures for now
does any of this depend on django-nonrel/django#22? |
@aburgel No, django-nonrel/django#22 isn't necessary for this to work. |
Support for Pymongo 3.0.
fields
keyword argument when calling find, as this has changed toprojection
in pymongo 3.0. Use positional argument instead.safe
andslave_okay
keyword arguments as these are no longer used and have been deprecated since 2.4Fix the broken tests.
DatabaseOperation.sqlflush
method to now check if a collection is capped before trying to remove the dataFixes #207 and #209