Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WsgiToAsgiInstance.build_environ()stripsroot_pathfrom the start ofpathwith a plainstartswith, so it also strips it whenroot_pathis only a prefix of the first path segment:PATH_INFOthen doesn't even start with/.This only strips
root_pathwhen the path is exactlyroot_pathor continues with/after it, which is the same rule Starlette uses inget_route_path. OtherwisePATH_INFOis left as the full path, the same as it already is for paths that don't start withroot_pathat all.Tests: a parametrized
test_script_name_segment_boundarycovering an exact match, a trailing slash, a non-matching segment prefix (/basevs/basement/foo) and an emptyroot_path. The/basementcase fails onmain. The full test suite, black, isort and flake8 pass.