Extra attributes problem, fixes #202#215
Merged
benkonrath merged 1 commit intodjango:masterfrom Apr 3, 2016
Merged
Conversation
tests/test_generic/models.py
Outdated
| from localflavor.generic.models import IBANField | ||
|
|
||
|
|
||
| class Partner(models.Model): |
Member
There was a problem hiding this comment.
Can you rename this to something like UseNordeaExtentions to match IncludedCountriesModel? Same applies to the form.
Member
|
This looks good. Can you rename the classes that I indicated and then rebase / squash your commits into one? Thanks. |
vladimirnani
force-pushed
the
extra_fields_problem
branch
4 times, most recently
from
9d9bafc to
77b3e25
Compare
vladimirnani
force-pushed
the
extra_fields_problem
branch
from
77b3e25 to
b325234
Compare
Member
|
@vladimirnani Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem was that attributes were not passed to formfield validators, only to field validators.