Skip to content

Adding local flavor for Venezuela#245

Merged
benkonrath merged 2 commits intodjango:masterfrom
jackboot7:master
Dec 1, 2016
Merged

Adding local flavor for Venezuela#245
benkonrath merged 2 commits intodjango:masterfrom
jackboot7:master

Conversation

@jackboot7
Copy link
Copy Markdown
Contributor

@jackboot7 jackboot7 commented Oct 3, 2016

Changes

  • Added states and regions datada
  • Added forms helpers for select widgets.

All Changes

  • Add an entry to the docs/changelog.rst describing the change.

  • Add an entry for your name in the docs/authors.rst file if it's not
    already there.

  • Adjust your imports to a standard form by running this command:

    isort --recursive --line-width 120 localflavor tests

New Fields Only

  • Prefix the country code to all fields.
  • Field names should be easily understood by developers from the target
    localflavor country. This means that English translations are usually
    not the best name unless it's for something standard like postal code,
    tax / VAT ID etc.

Copy link
Copy Markdown
Member

@benkonrath benkonrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. There are a couple of mistakes in the data. On the English wikipedia page you can order the table by subdivision name which is how I found the problems.

You'll also need to rebase with master. Thanks.
https://en.wikipedia.org/wiki/ISO_3166-2:VE

#: A list of Venezuelan states for use as `choices` in a formfield.
#: Data based from ISO_3166-2:VE http://en.wikipedia.org/wiki/ISO_3166-2:VE
STATE_CHOICES = (
('VE-X', _('Amazonas')),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VE-X -> VE-Z

('VE-G', _('Carabobo')),
('VE-H', _('Cojedes')),
('VE-Y', _('Delta Amacuro')),
('VE-Z', _('Dependencias Federales')),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VE-Z -> VE-W

('VE-R', _('Sucre')),
('VE-S', _('Táchira')),
('VE-T', _('Trujillo')),
('VE-W', _('Vargas')),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VE-W -> VE-X

@jackboot7
Copy link
Copy Markdown
Contributor Author

Hi, @benkonrath thanks for your comments. I already fixed the data errors on my local copy based on your feedback.

What do you mean with:

rebase with master

.

- Adds data and Select Widget for Venezuela regions
- Adds data and widget to select venezuelan states

- Adds changelog and author information to doc files

- Adds tests
@benkonrath
Copy link
Copy Markdown
Member

@jackboot7 Here's a guide that found that explains how to do a rebase:
https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

You'll have to resolve the conflict in the authors file. I can understand that it might a little overwhelming so I can resolve and merge this pull request if you prefer. Just let me know.

@jackboot7
Copy link
Copy Markdown
Contributor Author

@benkonrath Fixed the conflicts and rebased the code. Still not sure if I did the rebasing thing the right way... Anyway, if you have any comments they'll be appreciated.

@benkonrath benkonrath merged commit 6f63755 into django:master Dec 1, 2016
@benkonrath
Copy link
Copy Markdown
Member

Looks good. Thanks for your contribution to django-localflavor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants