Add local flavor for Ukraine.#273
Conversation
illia-v
force-pushed
the
Ukrainian-localflavor
branch
2 times, most recently
from
666e57c to
b06bbfd
Compare
benkonrath
left a comment
benkonrath
left a comment
There was a problem hiding this comment.
Thanks for your contribution. It came a little late to get it into 1.4 but I'm hoping to do a 1.5 release in a month or two so you shouldn't have to wait too long to get this into a release version of localflavor.
localflavor/ua/forms.py
Outdated
| """ | ||
| A Select widget that uses a list of Ukrainian regions as its choices. | ||
|
|
||
| .. versionadded:: 1.4 |
There was a problem hiding this comment.
I'd like to target 1.5 for this PR. Please change all versionadded labels to 1.5.
localflavor/ua/ua_regions.py
Outdated
| #: 24 oblasts, Autonomous Republic of Crimea and 2 cities with special status | ||
| # Codes were gotten from KOATUU | ||
| UA_REGION_CHOICES = ( | ||
| ('71', _('Cherkasy Oblast')), |
There was a problem hiding this comment.
I would prefer that you use ISO_3166-2:UA for the stored code instead of KOATUU. According to the KOATUU English wikipedia page, KOATUU will be integrated into ISO_3166-2:UA at some point in the future. Using the ISO standard also simplifies the discussion around disputed territories because we can just follow the standard. Does using ISO_3166-2:UA make sense to you?
I should point out that not everybody will be happy with ISO_3166-2:UA in regards to Crimea and Sevastopol being part of Ukraine. The solution you've implemented should allow developers to monkey-patch a region list that is suitable for their target audience so I'm ok with this PR being merged with Crimea and Sevastopol in the list.
illia-v
force-pushed
the
Ukrainian-localflavor
branch
from
3c09cb6 to
fbb975e
Compare
|
@benkonrath, thanks. I have changed what you requested. |
illia-v
force-pushed
the
Ukrainian-localflavor
branch
from
dc20049 to
000772a
Compare
|
Thanks for switching to the ISO 3166-2:UA codes. I meant that only the codes should be changed, not the name of the regions. It's better to use the English version of the region names instead of the transliterated region names because English is the base language for translations. You can find the English names on this page: Sorry for the confusion. Does this make sense to you? |
|
@benkonrath, changed that. Sorry for delay. |
|
Thanks again for your contribution! |
2 participants
No description provided.