Skip to content

Dropped support for Django < 1.11 and added support for Django 2.0.#310

Merged
benkonrath merged 2 commits intodjango:masterfrom
timgraham:drop-old-djangos
Nov 24, 2017
Merged

Dropped support for Django < 1.11 and added support for Django 2.0.#310
benkonrath merged 2 commits intodjango:masterfrom
timgraham:drop-old-djangos

Conversation

@timgraham
Copy link
Copy Markdown
Member

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 18, 2017

Codecov Report

Merging #310 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   96.28%   96.24%   -0.04%     
==========================================
  Files         156      155       -1     
  Lines        4415     4373      -42     
  Branches      592      591       -1     
==========================================
- Hits         4251     4209      -42     
  Misses        103      103              
  Partials       61       61
Impacted Files Coverage Δ
localflavor/si/forms.py 100% <100%> (ø) ⬆️
localflavor/cz/forms.py 93.54% <100%> (-0.11%) ⬇️
localflavor/es/forms.py 100% <100%> (ø) ⬆️
localflavor/au/forms.py 89.83% <100%> (-0.17%) ⬇️
localflavor/ee/forms.py 96.66% <100%> (ø) ⬆️
localflavor/no/forms.py 88.04% <100%> (-0.13%) ⬇️
localflavor/za/forms.py 100% <100%> (ø) ⬆️
localflavor/is_/forms.py 100% <100%> (ø) ⬆️
localflavor/pe/forms.py 62.85% <100%> (-1.04%) ⬇️
localflavor/kw/forms.py 89.36% <100%> (-0.23%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a4948...28cba94. Read the comment docs.

@timgraham timgraham changed the title Dropped support for Django < 1.11. Dropped support for Django < 1.11 and added support for Django 2.0. Oct 18, 2017
@benkonrath
Copy link
Copy Markdown
Member

Thanks @timgraham. Sorry for the delay in getting to this. Things have been busy for me but I have some breathing room these days.

I did already notice that it was going to be hard to support all of the officially supported version of Django when 2.0 comes out. Dropping support for the older versions seems like a good solution. I plan to make a 1.6 release soon and then I'll look more closely at this PR.

@benkonrath
Copy link
Copy Markdown
Member

benkonrath commented Nov 24, 2017

@timgraham This looks good. It just needs to be rebased and it can be merged. There are a couple of new fields added since this PR was submitted so they'll need to be updated as well. The failing tests should point you in the new fields. Let me know if you'd like me to rebase this instead - it's not a problem.

@timgraham
Copy link
Copy Markdown
Member Author

Done

@benkonrath benkonrath merged commit 28cba94 into django:master Nov 24, 2017
@benkonrath
Copy link
Copy Markdown
Member

Thanks for your help with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants