Fix #210 -- Added VAT identifcation number validator#324
Merged
benkonrath merged 1 commit intodjango:masterfrom Feb 10, 2018
Merged
Fix #210 -- Added VAT identifcation number validator#324benkonrath merged 1 commit intodjango:masterfrom
benkonrath merged 1 commit intodjango:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 95.87% 95.88% +0.01%
==========================================
Files 153 153
Lines 3804 3818 +14
Branches 507 508 +1
==========================================
+ Hits 3647 3661 +14
Misses 96 96
Partials 61 61
Continue to review full report at Codecov.
|
Contributor
Author
|
ping @benkonrath |
Member
|
I'll be able to look at this in a couple of days. |
benkonrath
requested changes
Feb 5, 2018
Member
benkonrath
left a comment
benkonrath
left a comment
There was a problem hiding this comment.
Sorry for the delay on this - life has been keeping me busy these days.
It looks good. Could you rebase this and add a changelog entry and your name to the authors file if it's not already there? Thanks.
Contributor
Author
|
@benkonrath I added the author and change log entry. |
benkonrath
approved these changes
Feb 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.