Belarus localflavor

[samgans]

Hi! I've added the localflavor for Belarus!

Released:

1. A number of new form fields (related to passports, regions, and postal codes);
2. A number of new model fields with links to those of form fields;
3. Tests for proper validation;

[benkonrath]

Thanks for your PR! I'll try to review it in the next couple of days.

[benkonrath]

Thanks for the PR and sorry for the delay in getting to this.

There are a couple of changes that I think should be made to improve this a little.
Let me know if you have any comments about the things I mentioned. Or you'd prefer me to just implement the changes (since there was a big delay in the review).

The string freeze for the 3.1 release is planned in two days (20 May). If you have time for the updates in the next two days then we can try to get this in. Otherwise, it can be included in the next release.

[benkonrath]

• The country code should be in capital letters for consistency: ByPostalCodeField -> BYPostalCodeField

• I think it's better if we use forms.RegexField instead of forms.CharField since the postal code is exactly 6 digits. That way we don't need to use max/min 6 and the duplicate (and possibly confusing) error messages.

[benkonrath]

Instead of making ChoiceField for the regions, I think it's better to make a forms.Select widget that can be used in forms. The BY_REGIONS_CHOICES can be set directly on the model instead of using this custom form field.

Here's an example of a forms.Select widget:

django-localflavor/localflavor/md/forms.py

Lines 35 to 43 in 456dd7e

	class MDCompanyTypesSelect(forms.Select):
	"""
	A Select widget that uses a list of Moldavian company types as its choices.
	.. versionadded:: 2.1
	"""
	def __init__(self, attrs=None):
	super().__init__(attrs, choices=COMPANY_TYPES_CHOICES)

[benkonrath]

I don't think it's a good idea to use None as the default for empty value. 'empty_value': None should be remove from the initial_options and this code should be updated like this:

Suggested change

	if value is None:
	return value
	if value in self.empty_values:
	return self.empty_value

This will let users set None if they prefer this. Otherwise an empty string will be used.

[benkonrath]

max_length isn't needed as the regex will take care of checking the length. The same applies to other places with max_length is set with a regex that enforces the length (below).

[benkonrath]

I think it's better to set choices to BY_REGIONS_CHOICES instead of using BYRegionFormField for the choices_form_class.

Here's an example:

django-localflavor/localflavor/md/models.py

Lines 37 to 54 in 456dd7e

	class MDCompanyTypeField(CharField):
	"""
	A model field for the Moldavian company type abbreviation.
	.. versionadded:: 2.1
	"""
	description = _("Moldavian company types")
	def __init__(self, *args, **kwargs):
	kwargs['choices'] = COMPANY_TYPES_CHOICES
	kwargs['max_length'] = 5
	super().__init__(*args, **kwargs)
	def deconstruct(self):
	name, path, args, kwargs = super().deconstruct()
	del kwargs['choices']
	return name, path, args, kwargs

[benkonrath]

I think it's better to have a few valid and invalid examples like this so that tests will never get a false positive or negative. That said, the chances are pretty low that there will be problems so feel free to keep things like this if this is what you prefer.

[benkonrath]

Moved this to the 4.0 milestone as I didn't have time to make the changes in the last couple of days.