Fix MX curp field#449
Merged
benkonrath merged 2 commits intodjango:masterfrom Aug 26, 2021
quevon24:fix-mx-curp
Merged
Conversation
Member
|
Thanks for the PR. A couple of points:
Thanks again for the fix! |
Contributor
Author
|
Thanks, I commited the new changes with what you ask for. I added an example to test_MXCURPField and the new entry on changelog. And thanks for this incredible package. 👍 |
Member
|
Thanks! ✋ (high five) |
netbsd-srcmastr
referenced
this pull request
in NetBSD/pkgsrc
Dec 2, 2023
4.0 (2023-04-22) ------------------ New flavors: - Nepal LocalFlavor: Support for Nepal added (`gh-451 <https://github.com/django/django-localflavor/pull/451>`_). - Belarus localflavor (`gh-422 <https://github.com/django/django-localflavor/pull/422>`_, `gh-442 <https://github.com/django/django-localflavor/pull/442>`_). - Ghana localflavor (`gh-460 <https://github.com/django/django-localflavor/pull/460>`_). New fields for existing flavors: - Added `fr.forms.FRRNAField` models field (`gh-443 <https://github.com/django/django-localflavor/pull/443>`_). - Added permanent account number(PAN) field in Indian flavor. (`gh-457 <https://github.com/django/django-localflavor/pull/457>`_). - Added the Canadian Models fields. (`gh-465 <https://github.com/django/django-localflavor/pull/465>`_). Modifications to existing flavors: - Properly validate IBANs using BBAN to ensure invalid IBANs cannot be entered, updated IBAN_SEPA_COUNTRIES and IBAN_COUNTRY_CODE_LENGTH to latest data (`gh-486 <https://github.com/django/django-localflavor/pull/486>`_). - Fix typo in Marijampolė county name in LTCountySelect (`gh-480 <https://github.com/django/django-localflavor/pull/480>`_). - Add support for new Finnish identity codes (`gh-478 <https://github.com/django/django-localflavor/pull/478>`_). - CIF spanish starting with 'U' bug resolved (`gh-469 <https://github.com/django/django-localflavor/pull/469>`_). - Fix error code for BRPostalCodeValidator (`gh-448 <https://github.com/django/django-localflavor/pull/448>`_). - Fix spelling of the India state of Chhattisgarh (`gh-444 <https://github.com/django/django-localflavor/pull/444>`_). - Fix CURP regex for MX flavor (`gh-449 <https://github.com/django/django-localflavor/pull/449>`_). - Change text based fields that inherited from `django.forms.Field` to inherit from `django.forms.CharField`. The following fields have been updated (`gh-446 <https://github.com/django/django-localflavor/pull/446>`_): - `at.forms.ATSocialSecurityNumberField` - `br.forms.BRStateChoiceField` - `ca.forms.CAProvinceField` - `ca.forms.CASocialInsuranceNumberField` - `ch.forms.CHIdentityCardNumberField` - `cu.forms.CUProvinceField` - `cu.forms.CURegionField` - `cz.forms.CZBirthNumberField` - `cz.forms.CZICNumberField` - `de.forms.DEIdentityCardNumberField` - `ee.forms.EEBusinessRegistryCode` - `ee.forms.EEPersonalIdentificationCode` - `fi.forms.FISocialSecurityNumber` - `gr.forms.GRTaxNumberCodeField` - `hr.forms.HRJMBAGField` - `hr.forms.HRJMBGField` - `hr.forms.HRLicensePlateField` - `hr.forms.HRPostalCodeField` - `id_.forms.IDLicensePlateField` - `id_.forms.IDNationalIdentityNumberField` - `id_.forms.IDPostCodeField` - `il.forms.ILIDNumberField` - `in_.forms.INAadhaarNumberField` - `in_.forms.INStateField` - `ir.forms.IRIDNumberField` - `it.forms.ITVatNumberField` - `lt.forms.LTPostalCodeField` - `lv.forms.LVPersonalCodeField` - `lv.forms.LVPostalCodeField` - `no.forms.NOSocialSecurityNumber` - `nz.forms.NZBankAccountNumberField` - `pt.forms.PTCitizenCardNumberField` - `pt.forms.PTSocialSecurityNumberField` - `ro.forms.ROCountyField` - `tr.forms.TRIdentificationNumberField` - `us.forms.USStateField` - Removed inconvenient word VACA from CURP_INCONVENIENT_WORDS for MX flavor Other changes: - Use 'return value' when value is in the empty_values list (`gh-461 <https://github.com/django/django-localflavor/pull/461>`_). - Dropped support for Django 2.2, 3.0 and 3.1. - Dropped support for Python 3.5. - Added support for Python 3.10 and 3.11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct regex to validate MX CURP is:
It needs an X because the second character is the first vowel of the first last name(surname), in the case that there is no vowel, CURP comes with an X, e.g: For example mayan last name 'OY'() second char is a consonant, not vowel, so the the beginning of the curp it's OX and it's not valid with actual regex.