Merged
Conversation
added 2 commits
July 3, 2025 14:07
- Fix regon length regex - Fix regon validation for 14 digits
claudep
reviewed
Jul 5, 2025
docs/changelog.rst
Outdated
| - Allow formatted IBANs longer than 26 chars to be saved in `IBANField` | ||
| (`gh-522 <https://github.com/django/django-localflavor/pull/522>`_). | ||
| - Fix REGON validation for PL | ||
| (`gh-529 <https://github.com/django/django-localflavor/pull/529>`_). |
Member
There was a problem hiding this comment.
5.0 has been released, please add your note under the 5.1 section.
Contributor
Author
There was a problem hiding this comment.
Sorry about that, fixed.
claudep
approved these changes
Jul 11, 2025
Member
claudep
left a comment
claudep
left a comment
There was a problem hiding this comment.
Thanks, looks good!
@benkonrath, do you want to have a quick look before merging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed validation, because regex currently allows for strings from 9 to 14 digits, but only fixed 9 digits or 14 digits should be allowed. Additionally the checksum validation for last digit case (where modulo of checksum is equal 10) is handled incorrectly for 14 digits length string.