Skip to content

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Dec 16, 2025

This fixes the unittest failures on my Raspberry Pi 5 (based on Debian 13), with LDC.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#10911"

assert(beta(-0.5, real.infinity) == -real.infinity);
assert(cmp(beta(nextDown(-0.0L), 2*nextUp(+0.0L)), -0.0L) <= 0);
static if (real.mant_dig != 113) // TODO: yields 1 with quadruple precision, verify!
assert(cmp(beta(nextDown(-0.0L), 2*nextUp(+0.0L)), -0.0L) <= 0);
Copy link
Contributor Author

@kinke kinke Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about this one. Edit: The beta(…) result is a NaN apparently. Edit2: Whereas it's a negative NaN with 80-bit real.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to version(AArch64), as beta() yields a positive NaN for macOS arm64 CI too, with 64-bit real. Note that this AArch64/ARM(?) behavior isn't affected by setting the non-fast FPU mode in https://github.com/dlang/dmd/blob/c8e2ae291414f839de5a7635da09a03c63fed2f6/druntime/src/test_runner.d#L114-L152.

@kinke kinke marked this pull request as ready for review December 17, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants